fix: texture mapping in JuiceBox and node deletion bug in hierarchy

2026-09-02 10:05:44 +05:30
parent 35c688ba47
commit 7582d9b810
3 changed files with 32 additions and 2 deletions
@@ -62,6 +62,10 @@ export const JuiceBox = forwardRef<THREE.Group, any>(({
      ctx.fillText("REFRESHING FRUIT DRINK", 256, 150);
    }
    const tex = new THREE.CanvasTexture(canvas);
+    tex.colorSpace = THREE.SRGBColorSpace;
+    tex.wrapS = tex.wrapT = THREE.RepeatWrapping;
+    tex.repeat.set(-1, -1);
+    tex.offset.set(1, 1);
    tex.needsUpdate = true;
    return tex;
  }, [color, map]);
@@ -72,7 +76,8 @@ export const JuiceBox = forwardRef<THREE.Group, any>(({
    const tex = loader.load(map);
    tex.colorSpace = THREE.SRGBColorSpace;
    tex.wrapS = tex.wrapT = THREE.RepeatWrapping;
-    tex.repeat.set(uvScale, uvScale);
+    tex.repeat.set(-uvScale, -uvScale);
+    tex.offset.set(1, 1);
    return tex;
  }, [map, uvScale]);

@@ -244,6 +244,18 @@ export const ModelViewer = forwardRef<THREE.Group, ModelViewerProps>(({ object,
    }
  }, [object, sceneObjects]);

+  // Hide deleted meshes
+  useEffect(() => {
+    if (object && sceneObjects) {
+      const activeIds = new Set(sceneObjects.map(obj => obj.id));
+      meshCache.current.forEach((mesh, id) => {
+        if (!activeIds.has(id)) {
+          mesh.visible = false;
+        }
+      });
+    }
+  }, [object, sceneObjects]);
+
  if (!object) return null;

  const meshObjects = sceneObjects.filter(obj => obj.type === 'mesh');